Commit Graph
9 Commits
Author SHA1 Message Date
Claude c43eebbf9a docs(review-findings): dedupe with fable-idea, list owner decisions
- Replace the T2.b/T2.c/T2.d/F2 detail in the batch-3 note with a pointer:
  those items are tracked in fable-idea.md (and ARCHITECTURE §8.10).
- Tick the 2026-09 cleanup under Dead code.
- New "Owner decisions" checklist: reflected settings/fields and plain
  enums that nothing in Source/ reads but that assets, Blueprints, tools
  or tests may reference by name, so they were kept (sheet-ring settings,
  ceiling settings, DensityVolumeMaxTasks, unused audio/creature fields,
  biome WaterMaterial, EVoxelFace / EVoxelSeasonSelectionReason /
  EVoxelOpCombine, MaxDisplacement hooks).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01URDGLsu7c4nunqNFPJEFPU
2026-09-28 14:33:51 +00:00
Claude 46f7f5f7c1 docs(fable-idea): tick what the code already does, close F18
- Header: drop the false note that .gitignore ignores this file (the
  whitelist keeps every *.md) and the "nothing here is implemented" line.
- Perf §0 / F3 ticked: stat VoxelForge group (VoxelStats.h) + Insights
  scopes exist. F6 ticked (Stage 1): mesher writes FVoxelMeshData::Colors
  from MaterialPaletteIndex (ARCHITECTURE §8.15). F7 marked partly done
  (landmark AnchorMode/exclusion, FTerrainCondition, FDecoCompanion; SDF
  stamps not built).
- F18 far-field sheets: marked REMOVED (owner decision) with what remains
  (unused settings, runtime passes false).
- Suggested-order list annotated with what is done and what is open.
- T1.b status no longer repeats the dead-trio removal (tracked in
  REVIEW_FINDINGS dead code).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01URDGLsu7c4nunqNFPJEFPU
2026-09-28 14:33:51 +00:00
Claude 26fbf0c999 docs(architecture): drop the sheet ring, fix content/water to match code
- §8.10 render-distance paragraph: remove the F18 far "sheet" ring
  description (GenerateSheetMesh, SheetHole*, sheet re-queue). The ring
  is plain level-MaxClipLevel MC tiles; bFarSheetRing/FarSheetSpanLevels
  are documented as unused settings the runtime always passes as false.
  All other §8.10 invariants are kept; the budgeted-teardown note now says
  what UnloadTile does today (park the component), not ClearChunk.
- Fix the claim that GetLODForChunk/LODToStep/IsChunkInRange/
  GetStrateChunkZBounds and the ViewDistance settings are dead (the first
  three are gone, the last two are used); only the ceiling settings are.
- §8.5: decoration results are BuildId-guarded region builds applied by
  ApplyRegion (no ReadyResults/DecoEpoch/ApplyDecoResult); water is one
  player-following plane (UpdateWater), not per-tile planes; palette tags
  are per-grid EntryBiome; FStrateSetPiece no longer "coming" (folded into
  landmarks); drop the dead ContentMaxLevel/MaxLODLevel notes.
- §9.3: anchors fold in after the player clipmap (no sheet ring).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01URDGLsu7c4nunqNFPJEFPU
2026-09-28 14:31:24 +00:00
Claude c91b63d7c2 docs(codemap): refresh line hints, drop removed symbols
- Refresh every numeric line hint in the §3 tables, the §4 pipeline step
  anchors, the §5 "go here" table and the inline (h:NNN) / (NNN) hints;
  most pointed at a much older file layout (e.g. AVoxelWorld at 12,
  now 176; GetDensityWithParams at 277, now 3851).
- Remove rows/mentions of symbols that no longer exist: the far sheet
  ring (GenerateSheetMesh, SheetHole*, sheet-tile routing in LoadTile and
  BuildDesiredTiles), EvaluateSDF, the generator's ApplyPassageCarving
  forwarder, VoxelTypes chunk-local helpers (LocalToIndex & co.,
  CHUNK_SIZE_SQUARED/CHUNK_VOLUME), GetLODForChunk/LODToStep,
  VF_RollStrateParams (now VF_RollStrateParamsDetailed), and the stale
  AVoxelWorld storage list (Chunks/ChunkMeshes/ChunkLODs/PendingChunkCoord
  -> LoadedTiles/TileComponents/PendingTiles + the four MPSC queues).
- bFarSheetRing / FarSheetSpanLevels are documented as unused settings.
- Add the 13 test files that were missing from §3.12.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01URDGLsu7c4nunqNFPJEFPU
2026-09-28 14:27:51 +00:00
Claude 26984d38d8 docs(comments): drop history narration, keep the why
Rewrite comments that told the story of past rounds instead of the
current code: dated "fixed on / tried on / reverted on" notes, "this used
to...", "stale paragraph removed", "Phase 1/2" progress labels, and the
"ClassifyTile still does not use ClassifyBox" claim (it does now, via
VF_ClassifyBoxWithWarpRetry). Every invariant, unit, sign convention,
trap and measurement that justified the design is kept, rephrased in the
present tense and in its original language (French or English).

Also fix comments that named symbols removed in the dead-code commit
(EvaluateSDF wrapper, FTunnelCoreWorldEvaluation support-floor fields,
BlendChunks -> TransitionBlendChunks) and the stale function name in the
VF_RollStrateParamsDetailed determinism checkf message.

Comment and message text only; no code token changed. Tests untouched.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01URDGLsu7c4nunqNFPJEFPU
2026-09-28 14:18:36 +00:00
Claude 6fd8a88986 chore(logs): drop hard-coded temporary probe logs
Remove three one-off investigation aids pinned to one seed/coordinate:
- [VoxelForgeExplore][TemporaryShaftConnectors] in the shaft connector
  op's Eval (a thread_local flag + coordinate test in the density path);
- [VoxelForgeExplore][TemporaryVerticalLanding] in the vertical-shaft
  landing search (seed 14, bottom Z -736 only);
- [VoxelForgeExplore][TemporaryShaftProbe] in the explore commandlet walk
  mode (seed 14 VerticalShafts only; its own comment said it would be
  removed once the seam was fixed).

No tool, test or script matches these tags (Tools/*.ps1 only parse
[VoxelForgeExplore][OwnerAssets] under that prefix). The probe's density
reads were log-only, so generated geometry and reports are unchanged.
All cvar-gated diagnostics and test result lines are kept.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01URDGLsu7c4nunqNFPJEFPU
2026-09-28 14:10:36 +00:00
Claude 3f629f407a refactor(dead-code): remove functions, members and types with no caller
Each symbol below had zero references in Source/ (tests included), Tools/,
Config/ and the build files after comment/string stripping.

Functions: EvaluateTunnelCoreSDF, EvaluateSDF (uncached wrapper),
IsTunnelSupportFloorWorldPoint, BuildTunnelSupportFloorColumn,
IsTunnelSupportFloorColumnZ, GetTunnelSupportFloorColumnBand,
VF_TunnelFloorAtSegment, VF_ProjectSweptTunnelFloor, FVoxelWormField
EvaluateExact, ApplyPassageLandingAirMC, ApplyPassageTunnelAirMC,
GetGenerationParamsFingerprint, FVoxelStrateCorpus::LoadFromSettings,
GetSkippedDefinitions, VF_RollStrateParams, VF_ArePlayerFitConnectedWithSampler,
VF_GetVoxelSeasonSelectionReasonName, UVoxelSeasonAsset::GetManifestContentHash,
FVoxelStackSampler::IsRunning, CompareSkippedPostValue,
MakeSurfaceColumnSource, WriteObjTile, ExploreEffectName,
ExploreTileClassName, and the VoxelTypes.h chunk-local helpers
(WorldToLocalCoord, ChunkToWorldPos, LocalToIndex, IndexToLocal,
IsValidLocalCoord, GetFaceDirection, GetFaceNormal, CHUNK_SIZE_SQUARED,
CHUNK_VOLUME).

Members/types: write-only floor flags (FVoxelOpSample::
bProtectedStructuralFloor, StructuralFloorMinimumDensity,
bTunnelCoreSupportFloor; bSupportFloor on the tunnel evaluations;
FTunnelFloorSegmentProfile::NumSteps), UVoxelStrateManager::BlendChunks,
unused FSummary counters in the stack sampler, two unused
FVoxelSeasonCompositionSettings aliases, and a few unused locals/constants.

No UPROPERTY, UFUNCTION, reflected type or enum was touched. Behaviour is
unchanged: removed code was unreachable or only written, never read.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01URDGLsu7c4nunqNFPJEFPU
2026-09-28 14:09:05 +00:00
Claude 4753416d4a refactor(sheets): remove the far sheet ring from the runtime
The owner dropped the far sheet ring. Remove it from the streaming path:
- UVoxelMarchingCubesMesher::GenerateSheetMesh (declaration + definition);
- sheet-tile branches in LoadTile / GenerateTileResult / SyncRemeshTile and
  the bSheetTile / SheetChunkZ / Hole* parameters;
- the SheetHole* XY-hole state and its per-crossing re-queue block;
- VF_MaxMarchingCubesLevel (equal to the clamped MaxClipLevel without sheets);
- the sheet-only band arming and the 'sheet' field of the desired-level
  startup-trace events (no tool reads it).

AVoxelWorld now always passes bFarSheetRing=false to the tile selector, and
the descendant index covers levels up to the MaxClipLevel clamp (8) instead
of the old sheet maximum (12); no tile above 8 can exist any more.

Kept on purpose: UVoxelSettings::bFarSheetRing / FarSheetSpanLevels
(UPROPERTYs, now marked unused), the voxel.TestFarSheetRing switch and the
far_sheet_ring / sheet_tile fields the test harness compares (sheet_tile is
always false), and the selector's sheet parameters in
VoxelClipmapDesiredTiles.h, which two automation tests still exercise.
2026-09-28 13:50:55 +00:00
Claude 1de44af7cc chore(repo): archive historical docs under Docs/archive, drop tracked pycache
Move closed audits, task briefs, design rounds, perf reports, the OPSTACK
plan/progress logs and WORK-NEXT.md into Docs/archive/ (git mv, history kept).
Whitelist Docs/ in the strict .gitignore, ignore Tools/**/__pycache__/, and
remove the tracked .pyc. Repoint references in the kept docs and in non-test
source comments to the new paths.
2026-09-28 13:46:17 +00:00